D9808: fix incorrect emission of signals by kLineEdit

Milian Wolff noreply at phabricator.kde.org
Thu Jan 11 09:00:04 UTC 2018


mwolff added inline comments.

INLINE COMMENTS

> klineedit_unittest.cpp:87
> +        
> +        //if text box is already clear, calling clear() shouldn't emit
> +        // any more signals

typo: if the text box is already clear*ed*

> anthonyfieroni wrote in klineedit.cpp:63
> You mean this is emitted by Qt and this is duplicate one or so?

I agree with dfaure, isn't this line here the only "real" change? The extended unit test is good too of course.

REPOSITORY
  R284 KCompletion

REVISION DETAIL
  https://phabricator.kde.org/D9808

To: dweatherill, #frameworks, dhaumann, cullmann
Cc: mwolff, dfaure, anthonyfieroni, iodelay, vbspam, njensen, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180111/fd67c996/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list