D9808: fix incorrect emission of signals by kLineEdit

David Faure noreply at phabricator.kde.org
Thu Jan 11 08:44:39 UTC 2018


dfaure added inline comments.

INLINE COMMENTS

> klineedit.cpp:184
>  
> -    q->connect(q, SIGNAL(textChanged(QString)), q, SLOT(_k_textChanged(QString)));
> +    q->connect(q, SIGNAL(textChanged(QString)), q, SLOT(_k_textEmitted(QString)));
>  }

Why did you rename the slot? I don't understand "textEmitted", and the signal is of course still called textChanged. Isn't the slot renaming just noise?

REPOSITORY
  R284 KCompletion

REVISION DETAIL
  https://phabricator.kde.org/D9808

To: dweatherill, #frameworks, dhaumann, cullmann
Cc: dfaure, anthonyfieroni, iodelay, vbspam, njensen, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180111/523c23c1/attachment.html>


More information about the Kde-frameworks-devel mailing list