D10803: handle more tags in taglibextractor

Michael Heidelbach noreply at phabricator.kde.org
Sun Feb 25 16:05:19 UTC 2018


michaelh added a comment.


  Nice! How do the infopanel or tooltips of dolphin look with this?

INLINE COMMENTS

> properties.h:164
>      /**
> -     * The language the document is written in. This directly maps to the
> +     * The language the document is written in. Thiof a media file.s directly maps to the
>       * 'dc:language' tag from DublinCore. We do NOT employ any language

?

> properties.h:168
>       */
>      Langauge,
>  

Will we break ABI with correct 'Language'?

> propertyinfo.cpp:586
>          { QStringLiteral("linecount"), Property::LineCount },
>          { QStringLiteral("language"), Property::Langauge },
>          { QStringLiteral("copyright"), Property::Copyright },

Language?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D10803

To: astippich, mgallien
Cc: michaelh, ngraham, #frameworks, kmorwinski
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180225/ec913792/attachment.html>


More information about the Kde-frameworks-devel mailing list