D10722: other preload microoptimizations
Marco Martin
noreply at phabricator.kde.org
Thu Feb 22 14:26:04 UTC 2018
mart added inline comments.
INLINE COMMENTS
> davidedmundson wrote in svgitem.cpp:50
> I don't see how this makes any difference.
>
> Every setSomeProperty already calls scheduleImageUpdate regardless of whether we're complete or not.
> and if you don't have any properties set, then there's nothing to polish.
when the component is complete, in many cases i guessthe properties would all be already set? (could add a check on that) could even be worth directly a loadPixmap, like an immediate updatePolish() there
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D10722
To: mart, #plasma
Cc: davidedmundson, broulik, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180222/68510aaf/attachment.html>
More information about the Kde-frameworks-devel
mailing list