D10722: other preload microoptimizations

David Edmundson noreply at phabricator.kde.org
Wed Feb 21 17:22:34 UTC 2018


davidedmundson added inline comments.

INLINE COMMENTS

> svgitem.cpp:50
>  
> +void SvgItem::componentComplete()
> +{

I don't see how this makes any difference.

Every setSomeProperty already calls scheduleImageUpdate regardless of whether we're complete or not.
and if you don't have any properties set, then there's nothing to polish.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10722

To: mart, #plasma
Cc: davidedmundson, broulik, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180221/10a529c7/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list