D10694: epubextractor: Handle multiple subjects better

Michael Heidelbach noreply at phabricator.kde.org
Tue Feb 20 18:54:50 UTC 2018


michaelh created this revision.
michaelh added reviewers: mgallien, dfaure.
michaelh added projects: Baloo, Dolphin, Frameworks.
Restricted Application added a subscriber: Frameworks.
michaelh requested review of this revision.

REVISION SUMMARY
  Instead of returing one long word of ';'-concatenated subjects,
  which is unwrappable return a list of strings and let the consumer handle it.
  
  This will facilitate e.g. dolphin's tooltips display of multiple subjects.
  
  - Add more subjects to test.epub

TEST PLAN
  unit test
  visual inspection in dolphin with adapted baloo-widgets

REPOSITORY
  R286 KFileMetaData

BRANCH
  multi-subject (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10694

AFFECTED FILES
  autotests/epubextractortest.cpp
  autotests/samplefiles/test.epub
  src/extractors/epubextractor.cpp

To: michaelh, mgallien, dfaure
Cc: #frameworks, ashaposhnikov, michaelh, spoorun, navarromorales, isidorov, nicolasfella, firef, andrebarros, alexeymin, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180220/76ca85d5/attachment.html>


More information about the Kde-frameworks-devel mailing list