D10578: balooctl monitor: Wait for dbus interface

Christoph Feck noreply at phabricator.kde.org
Sat Feb 17 15:00:07 UTC 2018


cfeck added inline comments.

INLINE COMMENTS

> michaelh wrote in monitorcommand.cpp:45
> You're right. I just looked at the example in Qt's coding style rules. In fact it is operators BOL, commas EOL.
> I'm ok with putting the commas at EOL (it's the rule, after all). Since to me it is more readable this way I'd like to wait for a second opinion or your objection.

I have only seen commas at the beginning of a line for constructor initializers, because adding a new one would affect two lines, instead of inserting a single new line. It just looks better in diffs.

Otherwise, yes, commas at the end, please.

REPOSITORY
  R293 Baloo

BRANCH
  wait-for-dbus (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10578

To: michaelh, dfaure, alexeymin
Cc: cfeck, alexeymin, #frameworks, ashaposhnikov, michaelh, spoorun, nicolasfella
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180217/8eb05c86/attachment.html>


More information about the Kde-frameworks-devel mailing list