<table><tr><td style="">cfeck added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10578" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10578#inline-50174" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">michaelh</span> wrote in <span style="color: #4b4d51; font-weight: bold;">monitorcommand.cpp:45</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">You're right. I just looked at the example in Qt's coding style rules. In fact it is operators BOL, commas EOL.<br />
I'm ok with putting the commas at EOL (it's the rule, after all). Since to me it is more readable this way I'd like to wait for a second opinion or your objection.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I have only seen commas at the beginning of a line for constructor initializers, because adding a new one would affect two lines, instead of inserting a single new line. It just looks better in diffs.</p>
<p style="padding: 0; margin: 8px;">Otherwise, yes, commas at the end, please.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R293 Baloo</div></div></div><br /><div><strong>BRANCH</strong><div><div>wait-for-dbus (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D10578" rel="noreferrer">https://phabricator.kde.org/D10578</a></div></div><br /><div><strong>To: </strong>michaelh, dfaure, alexeymin<br /><strong>Cc: </strong>cfeck, alexeymin, Frameworks, ashaposhnikov, michaelh, spoorun, nicolasfella<br /></div>