D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

Simone Gaiarin noreply at phabricator.kde.org
Tue Feb 13 17:55:40 UTC 2018


simgunz updated this revision to Diff 27084.
simgunz added a comment.


  - Automatically select first match of the filter
  - ArrowDown on lineEdit pass focus to QTreeView
  - Add tooltip to explain how to use the search filter
  - Fix code styling
  - Set appModel and proxyModel together, store proxyModel in data member
  - Avoid casts using pointer to proxyModel
  - Use fixed string case insensitive filter
  - Avoid cast by using member var to proxyModel
  - Initialize m_proxyModel to null pointer
  - Add access method to m_proxyModel, use it to avoid cast
  - Remove unuseful returns, call parent eventFilter if conditions unmatched
  - Fix OK button not disabled when category is selected
  - Fix cannot accept selection if filter line edit is empty

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8056?vs=27079&id=27084

BRANCH
  openwithdialog-filter-app-tree

REVISION DETAIL
  https://phabricator.kde.org/D8056

AFFECTED FILES
  src/widgets/kopenwithdialog.cpp
  src/widgets/kopenwithdialog.h
  src/widgets/kopenwithdialog_p.h

To: simgunz, dfaure, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, romangg, fabianr, abetts, ngraham, alexeymin, #frameworks, michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180213/c017ef1e/attachment.html>


More information about the Kde-frameworks-devel mailing list