D10416: When initialize devicePixelRatio when rendering into a pixmap

David Edmundson noreply at phabricator.kde.org
Fri Feb 9 23:52:27 UTC 2018


davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  > Fixes rendering of svg in many places, for example now icons don't look
  
  By editing FrameSVG? That seems unlikely.
  
  I think you've got some results mixed up.
  
  This patch doesn't change the resolution of anything. QPixmap::setDPR just sets metadata used when rendering using the sizes of one paint device when painting into another. However here we don't use the pixmap size, we use frame->frameSize...and then multiply it by the devicePixelRatio anyway on line 793.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10416

To: apol, #plasma, davidedmundson
Cc: davidedmundson, ngraham, plasma-devel, #frameworks, michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180209/d1249648/attachment.html>


More information about the Kde-frameworks-devel mailing list