D10325: [KFileWidget] Hide places frame and header

Aleix Pol Gonzalez noreply at phabricator.kde.org
Tue Feb 6 15:33:00 UTC 2018


apol added inline comments.

INLINE COMMENTS

> kfilewidget.cpp:1351
>      placesDock = new QDockWidget(i18nc("@title:window", "Places"), q);
> -    placesDock->setFeatures(QDockWidget::DockWidgetClosable);
> +    placesDock->setFeatures(QDockWidget::NoDockWidgetFeatures);
> +    placesDock->setTitleBarWidget(new KDEPrivate::KFileWidgetDockTitleBar(placesDock));

Does it really make sense that it's a dock if it can't be interacted with?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10325

To: broulik, #plasma, #vdg, #frameworks, ngraham, mart
Cc: apol, markg, ngraham, plasma-devel, michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180206/1aa8aaa8/attachment.html>


More information about the Kde-frameworks-devel mailing list