D16671: Refactor embedded image extractor for greater extensibility

[Stefan Brüns]

bruns accepted this revision.
bruns added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> embeddedimagedata.cpp:207
> +        int dataPosition = pictureData.find('\0');
> +        if (dataPosition == -1) {
> +            return QByteArray();

You can check for `>= 0` and let the `-1` case fall through ...

> astippich wrote in embeddedimagedata.cpp:134
> Docs don't say, so I fed a musepack file into this codepath and it still ran without issues (no cover extracted of course). Good enough?

Yes, thanks.

REPOSITORY
  R286 KFileMetaData

BRANCH
  refactor_embedded_image

REVISION DETAIL
  https://phabricator.kde.org/D16671

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181205/22484ce8/attachment-0001.html>