D16671: Refactor embedded image extractor for greater extensibility

[Alexander Stippich]

astippich marked 2 inline comments as done.
astippich added inline comments.

INLINE COMMENTS

> bruns wrote in embeddedimagedata.cpp:134
> Does Taglib signal an error when it fails to parse the file? Or is calling pictureList() always safe?

Docs don't say, so I fed a musepack file into this codepath and it still ran without issues (no cover extracted of course). Good enough?

> bruns wrote in embeddedimagedata.cpp:148
> Not sure if this is an issue, but the old code only called `tag()->pictureList()` after `!tag()->isEmpty()` - is this safe without?
> Dito for oggFile above.

Yes, the list will be empty.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16671

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181205/b5388957/attachment.html>