D17270: [KUrlNavigator] List subdirs of a parent folder of an archive

Thomas Surrel noreply at phabricator.kde.org
Mon Dec 3 12:53:38 GMT 2018


thsurrel added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in kurlnavigatorbutton.cpp:414
> Or we could use mimetype detection like we do in `KUrlNavigator::Private::isCompressedPath()`.

What would be the clean way to expose this function ? I wouldn't like to duplicate the code.
And btw, the "if ((m_url.scheme() == QLatin1String("tar")) || (m_url.scheme() == QLatin1String("zip")))" condition was taken from KUrlNavigator::setLocationUrl, so there must be a bugfix to be made there as well with the 'krarc' case gregormi reports.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17270

To: thsurrel, #frameworks
Cc: elvisangelaccio, gregormi, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181203/78fa39d1/attachment.html>


More information about the Kde-frameworks-devel mailing list