D17270: [KUrlNavigator] List subdirs of a parent folder of an archive

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> gregormi wrote in kurlnavigatorbutton.cpp:414
> When I click a zip file I get this in the URL bar:
> 
>   krarc:/home/gregor/Downloads/kfk_10p.zip/
> 
> This could mean that "krarc" should be added to this if statement.

Or we could use mimetype detection like we do in `KUrlNavigator::Private::isCompressedPath()`.

> kurlnavigatorbutton.cpp:417
> +        // or is a parent directory.
> +        QDir test_dir(url.path());
> +        if (test_dir.exists()) {

Coding sytle: variable names need to be camelCase.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17270

To: thsurrel, #frameworks
Cc: elvisangelaccio, gregormi, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181201/1de9fe18/attachment-0001.html>