D16832: fix empty runner list after switching to new locale

David Edmundson noreply at phabricator.kde.org
Sun Dec 2 17:29:24 GMT 2018


davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  Dead runners will surely be empty on the first load. You could still have had a locale change then.
  
  Also, now I'm re-reading it you're relying on locales to always have unique strings. It's perfectly plausible that spanish and italian could have 1 word matching. Or two locales having an untranslated value. As long as 1 value remains the same this workaround won't work.

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D16832

To: shaforostoff, #plasma_workspaces, davidedmundson, #frameworks
Cc: kde-frameworks-devel, michaldybczak, sdepiets, michaelh, ngraham, bruns, skadinna, huftis
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20181202/f583aec8/attachment.html>


More information about the Kde-frameworks-devel mailing list