<table><tr><td style="">davidedmundson requested changes to this revision.<br />davidedmundson added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D16832">View Revision</a></tr></table><br /><div><div><p>Dead runners will surely be empty on the first load. You could still have had a locale change then.</p>
<p>Also, now I'm re-reading it you're relying on locales to always have unique strings. It's perfectly plausible that spanish and italian could have 1 word matching. Or two locales having an untranslated value. As long as 1 value remains the same this workaround won't work.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R308 KRunner</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D16832">https://phabricator.kde.org/D16832</a></div></div><br /><div><strong>To: </strong>shaforostoff, Plasma: Workspaces, davidedmundson, Frameworks<br /><strong>Cc: </strong>kde-frameworks-devel, michaldybczak, sdepiets, michaelh, ngraham, bruns, skadinna, huftis<br /></div>