D15189: [KRun] Don’t follow redirection to speed up and avoid incorrect behavior

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in krun.cpp:1319
> You cannot remove it, since it can be a local file, remote file with scheme that differs http and should be redirect then. So you can make it like that
> 
>   if (!job->url().scheme().startsWith("http")) {
>       setUrl(job->url());
>   }
> 
> Now it will not redirect only http and https.

Also you can add Qt::CaseInsensitive as second parameter to startsWith for scheme with capital letters.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15189

To: achauvel, #frameworks, dfaure, cfeck
Cc: anthonyfieroni, ngraham, kde-frameworks-devel, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180831/2bf9f603/attachment-0001.html>