D15189: [KRun] Don’t follow redirection to speed up and avoid incorrect behavior

Anthony Fieroni noreply at phabricator.kde.org
Fri Aug 31 19:29:52 BST 2018


anthonyfieroni added inline comments.

INLINE COMMENTS

> krun.cpp:1319
> -        // Update our URL in case of a redirection
> -        setUrl(job->url());
> -

You cannot remove it, since it can be a local file, remote file with scheme that differs http and should be redirect then. So you can make it like that

  if (!job->url().scheme().startsWith("http")) {
      setUrl(job->url());
  }

Now it will not redirect only http and https.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15189

To: achauvel, #frameworks, dfaure, cfeck
Cc: anthonyfieroni, ngraham, kde-frameworks-devel, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180831/4d3e4d78/attachment.html>


More information about the Kde-frameworks-devel mailing list