D13216: Overhaul the file index scheduler.

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> smithjd wrote in fileindexscheduler.cpp:117
> This starts a QRunnable at a negative priority (in this case the negative integer value for NewFiles) and then calls runnableStarted(NewFiles) with the enum of the started runnable.

Yeah, I suspected that - fugly as hell!

If you need different priorities, make it explicit.

> smithjd wrote in fileindexscheduler.h:92
> There is no cast from int to enum anywhere here. There is a cast fron enum to int, to a negative integer used to set the QRunnable thread priority.

Sigh ...
Make each state a bit in the flags. No bits set -> Idle, one or multiple bits set -> Suspended, or runners active.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13216

To: smithjd, bruns, mgallien
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180824/6c714c8f/attachment.html>