D13216: Overhaul the file index scheduler.

[James Smith]

smithjd added inline comments.

INLINE COMMENTS

> bruns wrote in fileindexscheduler.cpp:117
> Whats that supposed to do (I have an idea, but thats ugly ...)

This starts a QRunnable at a negative priority (in this case the negative integer value for NewFiles) and then calls runnableStarted(NewFiles) with the enum of the started runnable.

> bruns wrote in fileindexscheduler.h:92
> Make this a QFlags ...

There is no cast from int to enum anywhere here. There is a cast fron enum to int, to a negative integer used to set the QRunnable thread priority.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13216

To: smithjd, bruns, mgallien
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180824/43ae84ae/attachment.html>