D14990: [Icon Item] Watch KIconLoader icon change when using QIcon
Kai Uwe Broulik
noreply at phabricator.kde.org
Wed Aug 22 09:56:04 BST 2018
broulik created this revision.
broulik added reviewers: Plasma, TheAssassin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.
REVISION SUMMARY
`QIcon` is rendered through `KIconLoader` instead of e.g. `Plasma::Svg`. This means we need to recreate the pixmap when the icon theme changes.
CCBUG: 397109
TEST PLAN
- Pointed icon to a non-existing icon `foo`
- Created previously non-existing `hicolor` icon them efolder in `~/.local/share/icons` and added `foo` as an icon there
- Signalled icon change on dbus
- `IconItem` would reload and pick up that icon
Also see discussion in the bug report
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D14990
AFFECTED FILES
src/declarativeimports/core/iconitem.cpp
src/declarativeimports/core/iconitem.h
To: broulik, #plasma, TheAssassin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180822/62ec6fcf/attachment.html>
More information about the Kde-frameworks-devel
mailing list