<table><tr><td style="">broulik created this revision.<br />broulik added reviewers: Plasma, TheAssassin.<br />Herald added a project: Frameworks.<br />Herald added a subscriber: kde-frameworks-devel.<br />broulik requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D14990">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p><tt style="background: #ebebeb; font-size: 13px;">QIcon</tt> is rendered through <tt style="background: #ebebeb; font-size: 13px;">KIconLoader</tt> instead of e.g. <tt style="background: #ebebeb; font-size: 13px;">Plasma::Svg</tt>. This means we need to recreate the pixmap when the icon theme changes.</p>

<p>CCBUG: 397109</p></div></div><br /><div><strong>TEST PLAN</strong><div><ul class="remarkup-list">
<li class="remarkup-list-item">Pointed icon to a non-existing icon <tt style="background: #ebebeb; font-size: 13px;">foo</tt></li>
<li class="remarkup-list-item">Created previously non-existing <tt style="background: #ebebeb; font-size: 13px;">hicolor</tt> icon them efolder in <tt style="background: #ebebeb; font-size: 13px;">~/.local/share/icons</tt> and added <tt style="background: #ebebeb; font-size: 13px;">foo</tt> as an icon there</li>
<li class="remarkup-list-item">Signalled icon change on dbus</li>
<li class="remarkup-list-item"><tt style="background: #ebebeb; font-size: 13px;">IconItem</tt> would reload and pick up that icon</li>
</ul>

<p>Also see discussion in the bug report</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework (Library)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D14990">https://phabricator.kde.org/D14990</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/declarativeimports/core/iconitem.cpp<br />
src/declarativeimports/core/iconitem.h</div></div></div><br /><div><strong>To: </strong>broulik, Plasma, TheAssassin<br /><strong>Cc: </strong>kde-frameworks-devel, michaelh, ngraham, bruns<br /></div>