D14927: KConfig: handle directory symlinks correctly.

David Faure noreply at phabricator.kde.org
Sun Aug 19 11:34:27 BST 2018


dfaure created this revision.
dfaure added reviewers: adridg, arichardson.
Herald added a project: Frameworks.
Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks.
dfaure requested review of this revision.

REVISION SUMMARY
  When /home is a symlink, for instance (as is often the case on FreeBSD),
  group deletion would fail because KConfig was comparing non-canonical
  paths with canonical-paths:
  
  QDEBUG : KConfigTest::testDelete() Comparing "/home/adridg/.qttest/config/
  kconfigtest_subdir/kconfigtest" and "/usr/home/adridg/.qttest/config/
  kconfigtest_subdir/kconfigtest"

TEST PLAN
  mkdir /tmp/derp; ln -s /tmp/derp /tmp/drop
  HOME=/tmp/derp bin/kconfigtest testDelete  # Success
  HOME=/tmp/drop bin/kconfigtest testDelete  # Fail

REPOSITORY
  R237 KConfig

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14927

AFFECTED FILES
  src/core/kconfig.cpp

To: dfaure, adridg, arichardson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180819/19408870/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list