D14689: [KFileItem] Don't read directory comment on slow mounts

Anthony Fieroni noreply at phabricator.kde.org
Thu Aug 9 08:57:42 BST 2018


anthonyfieroni added inline comments.

INLINE COMMENTS

> dfaure wrote in kfileitem.cpp:816
> Shouldn't you check isSlow() at the end of the condition, or at least after isDir()? This way it wouldn't be checked for non-directories (you say it takes time...).

+1, at end will be better.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14689

To: broulik, #frameworks, dfaure, lbeltrame
Cc: anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180809/8d07e7ce/attachment.html>


More information about the Kde-frameworks-devel mailing list