D14689: [KFileItem] Don't read directory comment on slow mounts
David Faure
noreply at phabricator.kde.org
Thu Aug 9 08:51:02 BST 2018
dfaure added inline comments.
INLINE COMMENTS
> kfileitem.cpp:816
> // Support for .directory file in directories
> - if (isLocalUrl && isDir() && isDirectoryMounted(url)) {
> + if (isLocalUrl && !d->isSlow() && isDir() && isDirectoryMounted(url)) {
> QUrl u(url);
Shouldn't you check isSlow() at the end of the condition, or at least after isDir()? This way it wouldn't be checked for non-directories (you say it takes time...).
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D14689
To: broulik, #frameworks, dfaure, lbeltrame
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180809/12592551/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list