D14610: Use KLineEdit for folder name if folder has write access, else use QLabel

[Shubham]

shubham added a comment.


  In D14610#303706 <https://phabricator.kde.org/D14610#303706>, @rkflx wrote:
  
  > In D14610#303537 <https://phabricator.kde.org/D14610#303537>, @rkflx wrote:
  >
  > > `KPropertiesDialog::setFileNameReadOnly`
  > > `m_bFromTemplate`
  >
  >
  > @shubham Any comments on that (see my questions to @dfaure above)?
  
  
  sorry, don't know about it

INLINE COMMENTS

> rkflx wrote in kpropertiesdialog.cpp:988
> Without your patch, we only tested for `!itemList.supportsMoving()`. Now you also test for `(itemList.isDirectory() & !itemList.supportsWriting()`. Could you explain in what cases we need that new test? As far as I can see this blocks renaming the folder you removed the write permission from (while only its children should be prevented from being renamed).
> 
> (`&` instead of `&&` also caught my eye.)

this test was intended for blocking directories without write access to rename , but as you say it should be done to it's child

I missed that one & by mistake

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14610

To: shubham, rkflx, dfaure, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180805/73c68c6f/attachment.html>