drkonqi commit #d713184156759c3e3f5d5db045b893d2676ff7b3

[David Faure]

On samedi 4 août 2018 12:28:25 CEST René J.V. Bertin wrote:
> Hi,
> 
> I don't know if this is the best place to ask, but here goes:
> 
> I don't get drkonqi commit #d713184156759c3e3f5d5db045b893d2676ff7b3:

It's just a partial revert of abb6999b, so the assert is back to what it was.

> - it mentions drkonqi crashing on start ... but a functioning  Q_ASSERT will
> cause an abort which for all practical purposes is an induced crash

Exactly, so a wrong assert leads to an unwanted crash (in a debug build).

> - non-debug builds will simply ignore the test 

Sure, as always. Doesn't mean an assert shouldn't be correct :-)

> (and apparently, crash on launch).

I don't think so, the crash was in debug mode (= the assert).

-- 
David Faure, faure at kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5