D6513: Add support for Attica tags support

Christoph Feck noreply at phabricator.kde.org
Thu Aug 2 15:45:44 BST 2018


cfeck added inline comments.

INLINE COMMENTS

> ngraham wrote in atticaprovider.cpp:280
> Also isn't Qt `foreach` deprecated anyway? https://www.kdab.com/goodbye-q_foreach/

Ah, yes. `Q_FOREACH`, or C++11 `for (x : y)` if you see it does not cause unneeded detaches.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D6513

To: leinir, #knewstuff, apol, #kde_store, whiting, ahiemstra, mlaurent
Cc: cfeck, mlaurent, ngraham, ahiemstra, kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180802/aa14479f/attachment.html>


More information about the Kde-frameworks-devel mailing list