D6513: Add support for Attica tags support

Nathaniel Graham noreply at phabricator.kde.org
Thu Aug 2 15:28:23 BST 2018


ngraham added inline comments.

INLINE COMMENTS

> cfeck wrote in atticaprovider.cpp:280
> Space after `foreach`. No space after `&`.

Also isn't Qt `foreach` deprecated anyway? https://www.kdab.com/goodbye-q_foreach/

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D6513

To: leinir, #knewstuff, apol, #kde_store, whiting, ahiemstra, mlaurent
Cc: cfeck, mlaurent, ngraham, ahiemstra, kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180802/3769d1ed/attachment.html>


More information about the Kde-frameworks-devel mailing list