D12306: Filepicker dialog proper grid icon layout

[Henrik Fehlauer]

rkflx added inline comments.

INLINE COMMENTS

> kdiroperator.cpp:2594-2595
> +
> +        // Subtract 1 px to prevent the last column from missing
> +        // Reduce 4 more (scaled) pixels to prevent flickering when resizing the window
> +        const int viewPortWidth = itemView->contentsRect().width() - scrollBarWidth - 1 - 4 * itemView->devicePixelRatioF();

You got the reasoning wrong, please see my patch again and switch it around. 1px is against flickering, 4 px against the column problem (and include "Oxygen"!).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12306

To: anemeth, #frameworks, #vdg, ngraham, rkflx
Cc: abetts, rkflx, ngraham, #frameworks, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180419/8b6e4c1f/attachment.html>