D12306: Filepicker dialog proper grid icon layout

[Henrik Fehlauer]

rkflx added a comment.


  In D12306#250116 <https://phabricator.kde.org/D12306#250116>, @anemeth wrote:
  
  > @rkflx the 3px is causing flickering on Oxygen, 4px does not.
  
  
  I don't see this, but I'm also fine with 4px.
  
  > Also I can't reproduce the missing last column issue for Oxygen.
  
  Video for missing column (`4 *` removed):
  
  F5813782: KIO-column.webm <https://phabricator.kde.org/F5813782>
  
  Video for horizontal scrollbars:
  
  F5813783: KIO-scrollbars.webm <https://phabricator.kde.org/F5813783>
  
  > The itemsInRow == 1 part is for when there is one column only it should be centered, so I left 
  >  that in.
  
  No, please remove it. It's wrong because:
  
  - It only affects Oxygen (but the problem should be fixed there, not worked around).
  - Even for Oxygen it's not working right, because why would it be centered only for one column, while the items are off-centered for all other column counts?
  - It causes horizontal scrollbars for every widget style (see above).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12306

To: anemeth, #frameworks, #vdg, ngraham, rkflx
Cc: abetts, rkflx, ngraham, #frameworks, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180419/207b785f/attachment.html>