D11753: baloodb: Add clean command

Stefan BrĂ¼ns noreply at phabricator.kde.org
Mon Apr 16 16:36:43 UTC 2018


bruns added inline comments.

INLINE COMMENTS

> databasesanitizer.cpp:173
> +
> +    QMap<quint32, bool> deviceFilters(QVector<FileInfo>& infos, const DatabaseSanitizer::ItemAccessFilters accessFilter)
> +    {

Pass in a List/Set of deviceIds, and return the same type.

> michaelh wrote in databasesanitizer.cpp:343
> I'd like to keep it this way.
> 
> 1. For consistency with `printList` and `printDevices`
> 2. I'm thinking in the opposite direction: Make `sep` global to easily change it to another value for all output or even add a `field-separator` getter/setter ('--separator') should the need arise. (in a separate patch, of course)

My preference is:

- Use **one** fixed format string for human readable output, which is translatable
- When the need arises to e.g. have something machine readable, use a different format string.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11753

To: michaelh, #baloo, #frameworks, bruns
Cc: bruns, cfeck, smithjd, ashaposhnikov, michaelh, astippich, spoorun, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180416/b94d176a/attachment.html>


More information about the Kde-frameworks-devel mailing list