D12242: KJob public signals

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kjob.h:472
>       *
> -     * This is a private signal, it can't be emitted directly by subclasses of
> +     * @note: This is a private signal, it can't be emitted directly by subclasses of
>       * KJob, use setTotalAmount() instead.

"can't" should now be "shouldn't", since it's now technically possible, just strongly discouraged.

If we leave "can't" and someone tries it, it will work, and they'll think there is no problem then ;)

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D12242

To: jtamate, dfaure, #frameworks
Cc: michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180416/a294719e/attachment.html>