<table><tr><td style="">dfaure requested changes to this revision.<br />dfaure added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D12242">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12242#inline-61826">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kjob.h:472</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">     <span style="color: #aa2211">*</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">     <span style="color: #aa2211">*</span> <span class="n">This</span> <span class="n">is</span> <span class="n">a</span> <span class="n">private</span> <span class="n">signal</span><span class="p">,</span> <span class="n">it</span> <span class="n">can</span><span class="err">'</span><span class="n">t</span> <span class="n">be</span> <span class="n">emitted</span> <span class="n">directly</span> <span class="n">by</span> <span class="n">subclasses</span> <span class="n">of</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">     <span style="color: #aa2211">*</span> <span class="bright"></span><span class="err"><span class="bright">@</span></span><span class="bright"></span><span style="color: #a0a000"><span class="bright">note</span></span><span class="bright"></span><span class="p"><span class="bright">:</span></span><span class="bright"> </span><span class="n">This</span> <span class="n">is</span> <span class="n">a</span> <span class="n">private</span> <span class="n">signal</span><span class="p">,</span> <span class="n">it</span> <span class="n">can</span><span class="err">'</span><span class="n">t</span> <span class="n">be</span> <span class="n">emitted</span> <span class="n">directly</span> <span class="n">by</span> <span class="n">subclasses</span> <span class="n">of</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">     <span style="color: #aa2211">*</span> <span class="n">KJob</span><span class="p">,</span> <span class="n">use</span> <span class="n">setTotalAmount</span><span class="p">()</span> <span class="n">instead</span><span class="p">.</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">"can't" should now be "shouldn't", since it's now technically possible, just strongly discouraged.</p>

<p style="padding: 0; margin: 8px;">If we leave "can't" and someone tries it, it will work, and they'll think there is no problem then ;)</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R244 KCoreAddons</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D12242">https://phabricator.kde.org/D12242</a></div></div><br /><div><strong>To: </strong>jtamate, dfaure, Frameworks<br /><strong>Cc: </strong>michaelh, ngraham, bruns<br /></div>