D12028: taglibextractortest: Add test for files with empty metadata

Stefan BrĂ¼ns noreply at phabricator.kde.org
Wed Apr 11 23:00:10 UTC 2018


bruns added inline comments.

INLINE COMMENTS

> michaelh wrote in taglibextractortest.cpp:231
> This converts the enums to strings. That way it is easier to spot which properties are responsible for the failure.

What he likely meant:
`TagLibExtractor plugin{this};`
instead of
`QScopedPointer<ExtractorPlugin> plugin(new TagLibExtractor(this));`

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D12028

To: michaelh, mgallien, #baloo, #frameworks
Cc: bruns, astippich, ashaposhnikov, michaelh, spoorun, ngraham, alexeymin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180411/56a229b0/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list