D11452: sanitizer: Improve device listing

Stefan BrĂ¼ns noreply at phabricator.kde.org
Mon Apr 9 19:14:33 UTC 2018


bruns added inline comments.

INLINE COMMENTS

> michaelh wrote in fsutils.cpp:111
> I agree completely and followed your suggestion. Currently I'm stuck, though. 
> Using Solid to obtain the  accessibilty info of volumes and network shares, it seems only `Solid::Block` provides the `major` and `minor` properties needed to map to `deviceId`. But network shares don't implement Block.  :-/ 
> Any ideas? Maybe that is the reason why BalooEngine isn't using Solid?

Which is good, as the device id is completely bogus, and changes dependent on mount order.

Also the inode is not generally stable for at least smb, as not every server supports inodes exported from the server, and can not when several server filesystems are exported as a single share.

baloo on network shares will likely never work.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11452

To: michaelh, #baloo, #frameworks
Cc: bruns, smithjd, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180409/742111b5/attachment.html>


More information about the Kde-frameworks-devel mailing list