D11452: sanitizer: Improve device listing
Michael Heidelbach
noreply at phabricator.kde.org
Mon Apr 9 17:50:30 UTC 2018
michaelh added inline comments.
INLINE COMMENTS
> michaelh wrote in fsutils.cpp:111
> I agree completely and followed your suggestion. Currently I'm stuck, though.
> Using Solid to obtain the accessibilty info of volumes and network shares, it seems only `Solid::Block` provides the `major` and `minor` properties needed to map to `deviceId`. But network shares don't implement Block. :-/
> Any ideas? Maybe that is the reason why BalooEngine isn't using Solid?
While implementing your "I can not come up with a reason ..." suggestion, I realized, the 'clean' command also needs `DeviceInfo` to exclude unmounted devices.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D11452
To: michaelh, #baloo, #frameworks
Cc: bruns, smithjd, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180409/922812b5/attachment.html>
More information about the Kde-frameworks-devel
mailing list