D12016: [ktexteditor] much faster positionFromCursor

[Jaime Torres Amate]

jtamate updated this revision to Diff 31733.
jtamate edited the summary of this revision.
jtamate edited the test plan for this revision.
jtamate added a reviewer: Frameworks.
jtamate added a comment.


  Cached the position in static variables of KateViewAccessible.
  The cache is invalidated when the signal Document::textChanged is received.
  Unfortunately, KateViewAccessible must inherit also QObject or connect will not work, because KateViewAccessible didn't inherit QObject.
  **Is this change Binary compatible?**
  
  At first I thought the changes will come in setText, but in my tests it has never been called.
  
  To check the correctness of the result, I've run the fast and slow paths in kate, with several windows over the same document, changing it in sereveral ways, and the results always match.

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12016?vs=31579&id=31733

REVISION DETAIL
  https://phabricator.kde.org/D12016

AFFECTED FILES
  src/CMakeLists.txt
  src/view/kateviewaccessible.cpp
  src/view/kateviewaccessible.h

To: jtamate, #kate, cullmann, #frameworks
Cc: cullmann, #frameworks, michaelh, kevinapavew, ngraham, bruns, demsking, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180409/db8a3fcd/attachment-0001.html>