D12016: [ktexteditor] much faster positionFromCursor
Christoph Cullmann
noreply at phabricator.kde.org
Sun Apr 8 09:16:46 UTC 2018
cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.
Hi,
I appreciate the intend to speed this up.
But I think, to do this proper, it might make more sense to cache the current position in the KateViewAccessible and invalidate it on changes to the document.
The way you do it now, it might not be correct if text changes occur in-between. (if I don't overlook something)
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D12016
To: jtamate, #kate, cullmann
Cc: cullmann, #frameworks, michaelh, kevinapavew, ngraham, bruns, demsking, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180408/26f8ed0f/attachment.html>
More information about the Kde-frameworks-devel
mailing list