D11987: [CopyJob] Pass resolved URL to finalDestUrl so looking up trash filename works
Kai Uwe Broulik
noreply at phabricator.kde.org
Fri Apr 6 15:02:57 UTC 2018
broulik created this revision.
broulik added reviewers: Frameworks, dfaure.
Restricted Application added a project: Frameworks.
broulik requested review of this revision.
REVISION SUMMARY
In case of `desktop:/` KIO which rewrites URLs, looking up the URL the trashed file got didn't work.
This resulted in `trash:/filename` being recorded by the undo manager which then failed to restore the file as it was actually trashed to e.g. `trash:/0-filename`
BUG: 391606
CHANGELOG: Undoing trashing files on the desktop has been fixed
TEST PLAN
I always looked in the wrong place, the undo manager code was all sane it was just that we tried to restore (using the direct rename shortcut) a file that didn't exist :(
Trashed a file on `desktop:/`, hit Ctrl+Z, file showed up again immediately.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D11987
AFFECTED FILES
src/core/copyjob.cpp
To: broulik, #frameworks, dfaure
Cc: michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180406/2c95082d/attachment.html>
More information about the Kde-frameworks-devel
mailing list