<table><tr><td style="">broulik created this revision.<br />broulik added reviewers: Frameworks, dfaure.<br />Restricted Application added a project: Frameworks.<br />broulik requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D11987">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>In case of <tt style="background: #ebebeb; font-size: 13px;">desktop:/</tt> KIO which rewrites URLs, looking up the URL the trashed file got didn't work.<br />
This resulted in <tt style="background: #ebebeb; font-size: 13px;">trash:/filename</tt> being recorded by the undo manager which then failed to restore the file as it was actually trashed to e.g. <tt style="background: #ebebeb; font-size: 13px;">trash:/0-filename</tt></p>
<p>BUG: 391606</p>
<p>CHANGELOG: Undoing trashing files on the desktop has been fixed</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>I always looked in the wrong place, the undo manager code was all sane it was just that we tried to restore (using the direct rename shortcut) a file that didn't exist :(</p>
<p>Trashed a file on <tt style="background: #ebebeb; font-size: 13px;">desktop:/</tt>, hit Ctrl+Z, file showed up again immediately.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D11987">https://phabricator.kde.org/D11987</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/core/copyjob.cpp</div></div></div><br /><div><strong>To: </strong>broulik, Frameworks, dfaure<br /><strong>Cc: </strong>michaelh, ngraham<br /></div>