D11925: [WIP] Add "SkipSwitcher" to API

[Martin Flöser]

graesslin requested changes to this revision.
graesslin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> sharvey wrote in plasmawindowmodel.h:110
> Correct version number? 5.45?

I normally update those just before pushing to the next frameworks release number.

> plasma-shell.xml:339
> +    <!-- Skip switcher -->
> +    <request name="set_skip_switcher" since="3">
> +        <description summary="make the window not appear in a switcher">

The since is wrong. It must be higher than the current version. You also need to increase the version number and I think this should be added as last request and not in between.

> plasma-window-management.xml:49
>        <entry name="virtual_desktop_changeable" value="1 << 17" since="3"/>
> +      <entry name="skipswitcher" value="1 << 18" since="3"/>
>      </enum>

Here also the since is wrong

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D11925

To: sharvey, hein, graesslin
Cc: graesslin, #frameworks, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180404/d25b029d/attachment.html>