<table><tr><td style="">graesslin requested changes to this revision.<br />graesslin added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D11925">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D11925#inline-59754">View Inline</a><span style="color: #4b4d51; font-weight: bold;">sharvey</span> wrote in <span style="color: #4b4d51; font-weight: bold;">plasmawindowmodel.h:110</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Correct version number? 5.45?</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I normally update those just before pushing to the next frameworks release number.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D11925#inline-59781">View Inline</a><span style="color: #4b4d51; font-weight: bold;">plasma-shell.xml:339</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d"><!-- Skip switcher --></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #00702a"><request</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"set_skip_switcher"</span> <span style="color: #354bb3">since=</span><span style="color: #766510">"3"</span><span style="color: #00702a">></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #00702a"><description</span> <span style="color: #354bb3">summary=</span><span style="color: #766510">"make the window not appear in a switcher"</span><span style="color: #00702a">></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">The since is wrong. It must be higher than the current version. You also need to increase the version number and I think this should be added as last request and not in between.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D11925#inline-59782">View Inline</a><span style="color: #4b4d51; font-weight: bold;">plasma-window-management.xml:49</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #00702a"><entry</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"virtual_desktop_changeable"</span> <span style="color: #354bb3">value=</span><span style="color: #766510">"1 << 17"</span> <span style="color: #354bb3">since=</span><span style="color: #766510">"3"</span><span style="color: #00702a">/></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #00702a"><entry</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"skipswitcher"</span> <span style="color: #354bb3">value=</span><span style="color: #766510">"1 << 18"</span> <span style="color: #354bb3">since=</span><span style="color: #766510">"3"</span><span style="color: #00702a">/></span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #00702a"></enum></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Here also the since is wrong</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R127 KWayland</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D11925">https://phabricator.kde.org/D11925</a></div></div><br /><div><strong>To: </strong>sharvey, hein, graesslin<br /><strong>Cc: </strong>graesslin, Frameworks, michaelh, ngraham<br /></div>