D11891: Fix crashes in NotifyByAudio when closing applications

[Albert Astals Cid]

aacid added inline comments.

INLINE COMMENTS

> rjvbb wrote in notifybyaudio.cpp:148-150
> Slightly better English:
> 
>   // since stopping a mediaobject means it wont't emit finished(). However,
>   // we can receive pending finished() signals that were already emitted after
>   // playback completed: phonon uses a queued connection for these signals.

I disagree it is a better explanation, i do understand my text better. the fact that it is a queued connection is important and needs to be at the beginning of the explanation and not at the end.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D11891

To: aacid, #frameworks, cullmann, rjvbb
Cc: cfeck, rjvbb, mpyne, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180403/606cd965/attachment.html>