D11891: Fix crashes in NotifyByAudio when closing applications

[Albert Astals Cid]

aacid added a comment.


  In D11891#238999 <https://phabricator.kde.org/D11891#238999>, @rjvbb wrote:
  
  > So the difference here is that `finishNotification` isn't called if `notification == nullptr`, with the crucial difference probably being the fact that `m` isn't added multiple times to the list of reusable items?
  
  
  Yes, that's the commit log says
  
  > Why isn't that logic part of `finishNotification()`? IOW, is there a valid reason for finishNotification to be called with a NULL `notification` argument but `m` that hasn't yet been moved from m_notifications to m_reusablePhotons?
  
  no, that should never happen.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D11891

To: aacid, #frameworks, cullmann, rjvbb
Cc: cfeck, rjvbb, mpyne, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180403/c9172c74/attachment.html>