D8043: KDirWatch : make methods virtual

[René J.V. Bertin]

rjvbb added a comment.


  I did see some symptoms that could only be explained by a memory layout change (and apparently caused by this patch). Shame I didn't notice that before posting (I only tested with recompiled code).
  
  Would it be possible to change the name of this virtualised class and use that to make a derived KDirWatch class that just reexports the methods as non-virtual (say with `using`) - would that change the memory layout too (possibly in even more subtle ways)?
  
  Anyway, pity. Making the class thread-safe internally will probably come with more overhead because it cannot use knowledge about how it's being used. It does look like KDW could do with an internal overhaul (but maybe what I perceive as an overly complex mess is a result of well-tested optimisation? ;)) Is there a reason a single QFSW instance is shared among all KDirWatch instances, for instance?

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D8043

To: rjvbb, #frameworks, mwolff, dfaure
Cc: dhaumann, cfeck, dfaure, mwolff, kde-frameworks-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170929/c21c668a/attachment.html>