D8043: KDirWatch : make methods virtual

[David Faure]

dfaure added a comment.


  > Using a KDirWatch per thread would still mean that they can be accessing the shared QFSW instance concurrently.
  
  Are you sure it's shared? d->fsWatcher isn't static.
  Could it be that QFSW itself uses a single static object internally? In that case it's QSFW that needs to be made threadsafe.
  
  And now that you mention it, I indeed made KDirWatch threadsafe already, at least as far as I could test it on Linux. E.g. KDirWatch::self() is thread-local.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D8043

To: rjvbb, #frameworks, mwolff, dfaure
Cc: dhaumann, cfeck, dfaure, mwolff, kde-frameworks-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170929/c6c31cc7/attachment.html>