D8024: Change icon for discard changes in a dialog to dialog-cancel

[Nathaniel Graham]

ngraham added a comment.


  Hmm, I think edit-delete is the correct icon here, for two reasons:
  
  1. That's what upstream Qt defaults to
  2. dialog-cancel is more appropriate for a Cancel button (in fact that's what cancel is already using). But Discard is a more destructive action than Cancel: "Cancel" involvs not doing something you were about to do, while, "Discard" involves throwing away something that already exists. Therefore, the red trash can icon is IMHO more appropriate, since its color and icon signal that it is a destructive operation.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8024

To: davidedmundson, cfeck
Cc: ngraham, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170928/6bc680b7/attachment.html>