<table><tr><td style="">ngraham added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8024" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Hmm, I think edit-delete is the correct icon here, for two reasons:</p>
<ol class="remarkup-list">
<li class="remarkup-list-item">That's what upstream Qt defaults to</li>
<li class="remarkup-list-item">dialog-cancel is more appropriate for a Cancel button (in fact that's what cancel is already using). But Discard is a more destructive action than Cancel: "Cancel" involvs not doing something you were about to do, while, "Discard" involves throwing away something that already exists. Therefore, the red trash can icon is IMHO more appropriate, since its color and icon signal that it is a destructive operation.</li>
</ol></div></div><br /><div><strong>REPOSITORY</strong><div><div>R236 KWidgetsAddons</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D8024" rel="noreferrer">https://phabricator.kde.org/D8024</a></div></div><br /><div><strong>To: </strong>davidedmundson, cfeck<br /><strong>Cc: </strong>ngraham, Frameworks<br /></div>